-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EuiComboBox with single selection and custom option should not show a list #1882
EuiComboBox with single selection and custom option should not show a list #1882
Conversation
I'll code review after Caroline has done a UX pass. |
Can/Should we also disabled the dropdown arrow button? Seems like it's a bit misleading that clicking the arrow no longer does anything. The alternative would be to allow forcing the dropdown to show when clicking the arrow, but not when just entering into the input. The latter may be more ideal but also more complicated. |
@cchaos Seems reasonable. I'll try the 2nd option. |
Updated to have the arrow button open the list regardless of single selection custom option state |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WFM! TY!
One thing I did notice is that in FF, combo box dropdowns won't close when the arrow is clicked.
Might be related to #1385
Don't forget a CL, and maybe a test would be helpful.
^ That's been a thing in FireFox, I guess (reproducable in the prod docs). Specifically, it has to do with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes LGTM, pulled & tested docs locally
Summary
Fixes #1872, in which an EuiComboBox with
singleSelection
andonAddCustomOption
re-opens the options list after adding a custom option even though no more selections can be made.If the custom option does not show in the options list, the user now must clear the search/selection before the options list will open.
@cchaos, let me know if I need to adjust experience further to get at what you intended
Checklist
- [ ] This was checked in mobile- [ ] This was checked in IE11- [ ] This was checked in dark mode- [ ] Any props added have proper autodocs- [ ] Documentation examples were added- [ ] This was checked for breaking changes and labeled appropriately- [ ] Jest tests were updated or added to match the most common scenarios- [ ] This was checked against keyboard-only and screenreader scenarios- [ ] This required updates to Framer X components