Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowing the last item in the breadcrumbs to be clickable. #1905

Merged
merged 7 commits into from
May 1, 2019
Merged

Allowing the last item in the breadcrumbs to be clickable. #1905

merged 7 commits into from
May 1, 2019

Conversation

daveyholler
Copy link
Contributor

Summary

The last item in the breadcrumbs will now be clickable if an href is provided.

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@daveyholler daveyholler requested a review from cchaos May 1, 2019 02:16
@daveyholler daveyholler mentioned this pull request May 1, 2019
Merged
cchaos
cchaos approved these changes May 1, 2019
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm, thanks fo doing that. Just had a couple copy suggestions.

CHANGELOG.md Outdated Show resolved Hide resolved
src-docs/src/views/breadcrumbs/breadcrumbs_example.js Outdated Show resolved Hide resolved
daveyholler and others added 3 commits May 1, 2019 11:14
@daveyholler
Merge branch 'master' into breadcrumb-link
3f475ed
@cchaos @daveyholler
Update CHANGELOG.md
356375b 
Co-Authored-By: daveyholler <daveyholler@gmail.com>
@cchaos @daveyholler
Update src-docs/src/views/breadcrumbs/breadcrumbs_example.js
a77b82e 
Co-Authored-By: daveyholler <daveyholler@gmail.com>
cchaos
cchaos reviewed May 1, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@daveyholler daveyholler merged commit 9ac2229 into elastic:master May 1, 2019
@chandlerprall chandlerprall mentioned this pull request May 2, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daveyholler @cchaos