Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: Allow multiple snippets #1908

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented May 1, 2019

You can now also pass an array of strings to break the snippets into multiples. This is helpful for copy and pasting single snippets. It renders like so:

Screen Shot 2019-05-01 at 11 16 38 AM

@cchaos cchaos changed the title DOCS ONLY: Allow multiple snippets [DOCS]: Allow multiple snippets May 1, 2019
@cchaos cchaos changed the title [DOCS]: Allow multiple snippets [Docs]: Allow multiple snippets May 1, 2019
@cchaos cchaos added the documentation Issues or PRs that only affect documentation - will not need changelog entries label May 1, 2019
@ryankeairns
Copy link
Contributor

THANK YOU FOR DOING THIS!!!

Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🥇

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks @cchaos !

@cchaos cchaos merged commit 945dffc into elastic:feature/dynamic-euiicon May 2, 2019
@cchaos cchaos deleted the feature/dynamic-euiicon/snippets branch May 2, 2019 14:09
chandlerprall added a commit that referenced this pull request May 7, 2019
…rnal urls (#1924)

* Feature/icon breakapart (#1856)

* dynamic import

* Make the icon kinda work

* progress

* generate tsx from svg

* Build and commit icons TSX

* Updated Icon snapshots

* Updated EuiIcon build to again work in dependant projects

* Create a single eui.js build, bundling EuiIcon's dynamic import into the build

* Tests are passing

* Add a loading class to EuiIcon

* Added -isLoaded and using animations for fading

* update snapshots

* Remove background color from isLoaded state

* PR feedback

* Docs for EuiIcon new abilities (#1889)

Add docs for the custom svg abilities in EuiIcon

* DOCS ONLY: Allow multiple snippets (#1908)

* Update IconType and its proptype usage (#1913)

* Expand IconType to include string

* Update EuiIcon IconType to include Element, fix some TS issues, widen the EuiIcon IconType proptype

* Swap Vim example logo out for SVG example logo, which contains a viewBox for IE11 compat

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants