Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prettyInterval converted to TS #1920

Merged
merged 6 commits into from
May 9, 2019
Merged

prettyInterval converted to TS #1920

merged 6 commits into from
May 9, 2019

Conversation

theodesp
Copy link
Contributor

@theodesp theodesp commented May 7, 2019 •
edited
Loading

Summary

Converted prettyInterval to TS

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

thompsongl
thompsongl approved these changes May 7, 2019
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thompsongl
Copy link
Contributor

jenkins test this

@theodesp
Copy link
Contributor Author

theodesp commented May 8, 2019

@thompsongl Conflict resolved

@thompsongl
Copy link
Contributor

jenkins test this

@theodesp
Copy link
Contributor Author

theodesp commented May 8, 2019

@thompsongl Conflicts resolved

@thompsongl
Copy link
Contributor

jenkins test this

@theodesp
Copy link
Contributor Author

theodesp commented May 8, 2019

@thompsongl Conflicts resolved

@chandlerprall
Copy link
Contributor

Sorry for the conflicts!

@theodesp
Copy link
Contributor Author

theodesp commented May 9, 2019

Conflicts resolved here too

@thompsongl
Copy link
Contributor

jenkins test this

I'll merge as soon as these pass so you don't have to deal with anymore conflicts

@thompsongl thompsongl merged commit 022c74a into elastic:master May 9, 2019
@thompsongl thompsongl mentioned this pull request Jun 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thompsongl thompsongl thompsongl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@theodesp @elasticmachine @thompsongl @chandlerprall