Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack logo updated #1954

Merged
merged 2 commits into from
May 22, 2019
Merged

Slack logo updated #1954

merged 2 commits into from
May 22, 2019

Conversation

snide
Copy link
Contributor

@snide snide commented May 22, 2019

Summary

Fixes #1949

If you're thinking to yourself, "Hey Dave, that screenshot looks a little soft" know that I too thought the same thing, and then checked their website and saw it is also soft on their own provided files so I assume this is either intentional or possibly the work of a multi-million dollar rebranding campaign where simple details like the crispness of SVGs get overlooked.

image

image

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@snide snide requested review from ryankeairns and andreadelrio May 22, 2019 16:48
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snide snide merged commit 1c4f0cf into elastic:master May 22, 2019
@snide snide deleted the icon/slack branch May 22, 2019 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Slack logo icon
3 participants