Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for updating sorting prop and removing columns from EuiInMemoryTable after sorting is applied #1972

Merged
merged 5 commits into from
May 29, 2019

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented May 28, 2019

Summary

Fixes #1886, in which an error (TypeError: Cannot read property 'sortable' of undefined) would occur when the currently sorted column was removed. The intention of the action that caused the error was to also update the target sort column via the sorting prop. The latter action would have been an issue on its own because programmatically updating sorting after mount was not supported.

Checklist

- [ ] This was checked in mobile
- [ ] This was checked in IE11
- [ ] This was checked in dark mode
- [ ] Any props added have proper autodocs
- [ ] Documentation examples were added

  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately

- [ ] Jest tests were updated or added to match the most common scenarios
- [ ] This was checked against keyboard-only and screenreader scenarios
- [ ] This required updates to Framer X components

@thompsongl thompsongl requested a review from chandlerprall May 28, 2019 22:47
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM; needs a changelog

@thompsongl thompsongl merged commit c50b2f4 into elastic:master May 29, 2019
@thompsongl thompsongl deleted the 1886-sortable-column-change branch May 29, 2019 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InMemoryTable - Cannot read property 'sortable' of undefined when columns change
2 participants