Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiAccordion onToggle callback #1974

Merged
merged 6 commits into from
May 29, 2019

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented May 29, 2019

Summary

Closes #1860, which requested a callback on open and close of EuiAccordion. It passes one parameter, which is the new isOpen state of the accordion panel.

Checklist

- [ ] This was checked in mobile
- [ ] This was checked in IE11
- [ ] This was checked in dark mode

  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios

- [ ] This was checked against keyboard-only and screenreader scenarios
- [ ] This required updates to Framer X components

src/components/accordion/accordion.test.js Outdated Show resolved Hide resolved
src/components/accordion/accordion.test.js Outdated Show resolved Hide resolved
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the docs & test! Needs changelog :)

@thompsongl thompsongl merged commit f903564 into elastic:master May 29, 2019
@thompsongl thompsongl deleted the 1860-accordion-callback branch May 29, 2019 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add callback to EuiAccordion
2 participants