Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert tool tip components to TypeScript #2013

Merged
merged 4 commits into from
Jun 10, 2019
Merged

Convert tool tip components to TypeScript #2013

merged 4 commits into from
Jun 10, 2019

Conversation

pugnascotia
Copy link
Contributor

Summary

Convert tool tip components to TypeScript. I checked that the build still works and that the examples in the docs still operate.

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@chandlerprall chandlerprall self-assigned this Jun 10, 2019
chandlerprall
chandlerprall approved these changes Jun 10, 2019
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All updates LGTM, confirmed docs still work as expected. Requesting that one comment is removed, but don't want to block merging.

@pugnascotia pugnascotia merged commit 1d8596b into elastic:master Jun 10, 2019
@pugnascotia pugnascotia deleted the convert-tooltips-to-ts branch June 10, 2019 16:24
@thompsongl thompsongl mentioned this pull request Jun 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerprall chandlerprall chandlerprall approved these changes

@thompsongl thompsongl Awaiting requested review from thompsongl

Assignees

@chandlerprall chandlerprall

Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pugnascotia @chandlerprall