-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require that FormRow has exactly one child element #2054
Require that FormRow has exactly one child element #2054
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
jenkins test this |
1 similar comment
jenkins test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Don't forget to add a changelog entry
retest |
Thanks @wylieconlon !! |
Summary
EuiFormRow requires exactly one child element to work, which was too loose at runtime and compile time. This adds stricter type checks and a proptype check. The error messages are now much easier to follow:
Closes #1931
Screenshots showing updated errors:
Checklist
[ ] This was checked in mobile[ ] This was checked in IE11[ ] This was checked in dark mode[ ] This was checked against keyboard-only and screenreader scenarios