Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip TS type exports even when they are being renamed #2069

Merged

Conversation

chandlerprall
Copy link
Contributor

@chandlerprall chandlerprall commented Jun 20, 2019

Summary

Cleans up renamed exports of TS types, such as Toast as EuiGlobalToastListToast, in toast/index.ts. There were two instances of the same bug, where the value being exported was observed instead of the local variable name.

After applying the fix & re-running babel on toast/index.ts the new output is

export { EuiToast } from './toast';
export { EuiGlobalToastList } from './global_toast_list';
export { EuiGlobalToastListItem } from './global_toast_list_item';

I also ran icon/index.ts to confirm this did not affect the existing type removal when the variable is not renamed.

Checklist

- [ ] This was checked in mobile
- [ ] This was checked in IE11
- [ ] This was checked in dark mode
- [ ] Any props added have proper autodocs
- [ ] Documentation examples were added

  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
    - [ ] This was checked against keyboard-only and screenreader scenarios
    - [ ] This required updates to Framer X components

@chandlerprall chandlerprall requested a review from thompsongl June 20, 2019 19:54
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the expected output with local build

@chandlerprall chandlerprall merged commit 765704b into elastic:master Jun 20, 2019
@chandlerprall chandlerprall deleted the bug/strip-renamed-tstype-exports branch June 20, 2019 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants