Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiRange] Add missing TS definitions #2072

Merged
merged 3 commits into from
Jun 21, 2019
Merged

[EuiRange] Add missing TS definitions #2072

merged 3 commits into from
Jun 21, 2019

Conversation

sulemanof
Copy link
Contributor

@sulemanof sulemanof commented Jun 21, 2019 •
edited
Loading

Summary

Add missing type definitions valueAppend and valuePrepend to EuiRange

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

cchaos
cchaos approved these changes Jun 21, 2019
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

@sulemanof sulemanof merged commit bcf5140 into master Jun 21, 2019
@sulemanof sulemanof deleted the EuiRange/typescript_defs branch June 21, 2019 14:48
This was referenced Jun 24, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

@chandlerprall chandlerprall Awaiting requested review from chandlerprall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sulemanof @cchaos