Added display prop to EuiPopover
#2112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 11, 2019 18:44
To easily add `display: block`
cchaos
commented
Jul 11, 2019
| @@ -42,12 +42,12 @@ describe('EuiPopover', () => { | |||
| }); | |||
|
|
|||
| describe('props', () => { | |||
| describe('withTitle', () => { | |||
There was a problem hiding this comment.
withTitle is no longer a valid prop
chandlerprall
approved these changes
Jul 12, 2019
snide
approved these changes
Jul 12, 2019
Co-Authored-By: dave.snider@gmail.com <dave.snider@gmail.com>
thompsongl
approved these changes
Jul 12, 2019
snide
pushed a commit
to nreese/eui
that referenced
this pull request
Sep 12, 2019
* Added `display` option to EuiPopover * Updated color picker * Updated super date picker * Updated super select
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I got really tired of having to give the popover and the anchor a className in order to override the
display: inline-blockproperty. So I created a prop on the component so now you can easily pass downdisplay: "block"and it will apply to both elements.Also updated in the following usages
Checklist
[ ] This was checked in mobile[ ] This was checked in dark mode[ ] This was checked for breaking changes and labeled appropriately[ ] This was checked against keyboard-only and screenreader scenarios[ ] This required updates to Framer X components