Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert a range of EuiRange* components to TypeScript #2124

Merged
merged 8 commits into from
Jul 16, 2019

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Jul 15, 2019

Summary

A range of them 😏

Unfortunately, we can't yet convert the full suite as EuiFieldNumber is still JS.
Checked generated eui.d.ts in Kibana successfully.

Checklist

- [ ] This was checked in mobile
- [ ] This was checked in IE11
- [ ] This was checked in dark mode
- [ ] Any props added have proper autodocs
- [ ] Documentation examples were added

  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately

- [ ] Jest tests were updated or added to match the most common scenarios
- [ ] This was checked against keyboard-only and screenreader scenarios
- [ ] This required updates to Framer X components

@thompsongl thompsongl requested a review from chandlerprall July 15, 2019 21:02
@chandlerprall
Copy link
Contributor

Unfortunately, we can't yet convert the full suite as EuiFieldNumber is still JS.

I've got the converted EuiField* components on a branch, but there's one TS hurdle to figure out before those are ready to PR. (don't think that should block this PR, just wanted to call it out)

@thompsongl
Copy link
Contributor Author

don't think that should block this PR, just wanted to call it out

A separate PR for larger EuiRange and EuiDualRange components may be preferable anyway. Those will come with their own set of complications, I think

src/components/form/range/range_tooltip.tsx Outdated Show resolved Hide resolved
src/components/form/range/range_wrapper.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM; pulled and testing locally. Needs a changelog.

@thompsongl thompsongl merged commit fa84462 into elastic:master Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants