Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow EuiSearchBar group clauses to be negated #2140

Merged
merged 2 commits into from
Jul 18, 2019
Merged

Allow EuiSearchBar group clauses to be negated #2140

merged 2 commits into from
Jul 18, 2019

Conversation

chandlerprall
Copy link
Contributor

@chandlerprall chandlerprall commented Jul 18, 2019 •
edited
Loading

Summary

Closes #2107 by adding support for negated or clauses to EuiSearchBar.

negated or clause

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

thompsongl
thompsongl approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@chandlerprall chandlerprall merged commit eb9cce0 into elastic:master Jul 18, 2019
@chandlerprall chandlerprall deleted the feature/2107-negated-or-clause branch July 18, 2019 21:13
@snide snide mentioned this pull request Jul 22, 2019
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thompsongl thompsongl thompsongl approved these changes

@bevacqua bevacqua bevacqua approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support negated GroupClause in EuiSearchBar
3 participants
@chandlerprall @bevacqua @thompsongl