Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the TS defs for EuiFilterSelectItem #2192

Merged
merged 2 commits into from
Aug 5, 2019

Conversation

pugnascotia
Copy link
Contributor

The hand-rolled TS defs for EuiFilterSelectItem didn't work, so I applied the fix that I found worked for me.

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM; confirmed the issue locally and that the new definition resolves it

@pugnascotia pugnascotia merged commit 333bd7f into elastic:master Aug 5, 2019
@pugnascotia pugnascotia deleted the fix-filter-select-item-defs branch August 5, 2019 09:33
thompsongl pushed a commit to thompsongl/eui that referenced this pull request Sep 10, 2019
The hand-rolled TS defs for EuiFilterSelectItem didn't work, so I
applied the fix that I found worked for me.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants