Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced empty th with td #2934

Merged
merged 4 commits into from
Feb 26, 2020
Merged

Replaced empty th with td #2934

merged 4 commits into from
Feb 26, 2020

Conversation

anishagg17
Copy link
Contributor

@anishagg17 anishagg17 commented Feb 26, 2020

Summary

Fixes : #840
replaced empty th with td

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@anishagg17
Copy link
Contributor Author

@chandlerprall changes have been made

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick change to the added test case, otherwise this looks good.

src/components/table/table_header.test.tsx Outdated Show resolved Hide resolved
@anishagg17
Copy link
Contributor Author

@chandlerprall Changes have been made

@chandlerprall
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_2934/

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; pulled & tested locally

@chandlerprall chandlerprall merged commit eef48e9 into elastic:master Feb 26, 2020
@anishagg17 anishagg17 deleted the td branch February 26, 2020 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty table th elements should be replaced with td
3 participants