-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added prepend and append to EuiComboBox #3003
Added prepend and append to EuiComboBox #3003
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ashikmeerankutty There is actually a much easier solution for this.
EuiFormControlLayout
is the one that provides all the styling for the prepend and append elements. EuiComboBoxInput
is the component that renders via EuiFormControlLayout
, therefore, you just need to extend the prepend
/ append
prop types from this component and pass them down to EuiComboBoxInput
IF singleSelection
is true.
@cchaos updated Can you please review? |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3003/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks right but there's no way to test this. We'll need to add an example to the docs. @miukimiu Can you advise @ashikmeerankutty on what text to add. I'd assume we can just add the display toggles component to the single selection example.
When I triggered the preview build I noticed there was no way to test it. I had to test it locally and I noticed a few things.
NoteI created a PR ashikmeerankutty#1 that fixes these 3 issues. You can merge it or just follow it as an example. |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3003/ |
Adding props notes, displayToggles and styles
@miukimiu Thanks for the PR and suggestions. @cchaos Changes updated. Can you please review it? |
Jenkins, test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3003/ |
@cchaos Fixed 👍 |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3003/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you @ashikmeerankutty
Summary
Fixes #2943
Added prepend and append to Combobox if singleSelection is true
Summarize your PR. If it includes design elements include a screenshot or gif.
Checklist