Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Elastic logo loading component #3017

Merged
merged 5 commits into from
Mar 20, 2020
Merged

Add Elastic logo loading component #3017

merged 5 commits into from
Mar 20, 2020

Conversation

mdefazio
Copy link
Contributor

@mdefazio mdefazio commented Mar 9, 2020 •
edited
Loading

Summary

Adds an Elastic animated loading indicator.

Note: Potential animation performance issues noticed in some usages.

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@mdefazio mdefazio requested a review from snide March 9, 2020 19:38
snide
snide reviewed Mar 18, 2020
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review. I saw this in a draft state so didn't check it early. Some small comments. The animation is really nice. 🎉

src/components/loading/_loading_elastic.scss Outdated Show resolved Hide resolved
src/components/loading/loading_elastic.tsx Show resolved Hide resolved
@mdefazio mdefazio marked this pull request as ready for review March 20, 2020 16:39
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3017/

snide
snide approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add a changelog.

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3017/

@snide
Copy link
Contributor

snide commented Mar 20, 2020

Gonna help @mdefazio get this branch cleaned up before merging.

@mdefazio mdefazio force-pushed the loading-elastic-icon branch from 391c4c4 to 1e56818 Compare March 20, 2020 18:40
@cchaos cchaos mentioned this pull request Mar 20, 2020
Merged
6 tasks
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3017/

@mdefazio mdefazio merged commit 11826dc into elastic:master Mar 20, 2020
@chandlerprall chandlerprall mentioned this pull request Mar 31, 2020
Closed
@chandlerprall chandlerprall mentioned this pull request Apr 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snide snide snide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdefazio @kibanamachine @snide