Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial removal of lodash from charts, docs, selectable and datepicker components #3053

Merged
merged 12 commits into from
Mar 24, 2020
Merged

Partial removal of lodash from charts, docs, selectable and datepicker components #3053

merged 12 commits into from
Mar 24, 2020

Conversation

anishagg17
Copy link
Contributor

@anishagg17 anishagg17 commented Mar 12, 2020 •
edited
Loading

Summary

Makes progress on #360

Checklist

- [ ] Check against all themes for compatibility in both light and dark modes
- [ ] Checked in mobile
- [ ] Checked in IE11 and Firefox
- [ ] Props have proper autodocs
- [ ] Added documentation examples
- [ ] Added or updated jest tests

  • Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cchaos
Copy link
Contributor

cchaos commented Mar 12, 2020

Jenkins, test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3053/

@cchaos cchaos requested a review from chandlerprall March 12, 2020 16:03
chandlerprall
chandlerprall suggested changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting to dig into these!

For future changes, any dependencies on lodash inside test files can remain. We're mainly interested in removing it as a runtime dependency.

src-docs/src/views/selectable/selectable_popover.js Outdated Show resolved Hide resolved
packages/react-datepicker/docs-site/src/examples/render_custom_header.jsx Show resolved Hide resolved
@anishagg17
Copy link
Contributor Author

I have made the necessary changes

@anishagg17
Copy link
Contributor Author

anishagg17 commented Mar 17, 2020 •
edited
Loading

I have restored it and will remove it some other day

@chandlerprall
Copy link
Contributor

I have restored it and will remove it some other day

Also failing from the 3 other react-datepicker modifications,

  • packages/react-datepicker/test/month_dropdown_test.js
  • packages/react-datepicker/test/month_test.js
  • packages/react-datepicker/test/year_dropdown_test.js

@anishagg17
Copy link
Contributor Author

Screenshot 2020-03-19 at 1 04 04 PM

Finally, I resolved them at the right place

@anishagg17
Copy link
Contributor Author

anishagg17 commented Mar 20, 2020 •
edited
Loading

I have replaced it with (end - start + step - 1)/step as an alternative to Math.ceil method as I tested first one works as expected

chandlerprall
chandlerprall approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM; pulled & tested locally, including react-datepicker tests & docs

@chandlerprall
Copy link
Contributor

jenkins test this

@snide snide changed the title removed lodash dependency from various files Partial removal of lodash from charts, docs, selectable and datepicker components Mar 24, 2020
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3053/

@chandlerprall chandlerprall merged commit 0f6890a into elastic:master Mar 24, 2020
@anishagg17 anishagg17 deleted the lodash branch March 25, 2020 13:13
@chandlerprall chandlerprall mentioned this pull request Mar 31, 2020
Closed
@chandlerprall chandlerprall mentioned this pull request Apr 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thompsongl thompsongl thompsongl requested changes

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anishagg17 @kibanamachine @cchaos @chandlerprall @thompsongl