Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix padding in EuiCallout when used as banner for EuiFlyout #3098

Merged
merged 3 commits into from
Mar 17, 2020
Merged

Fix padding in EuiCallout when used as banner for EuiFlyout #3098

merged 3 commits into from
Mar 17, 2020

Conversation

andreadelrio
Copy link
Contributor

@andreadelrio andreadelrio commented Mar 17, 2020 •
edited
Loading

Summary

This PR aligns the content of a callout with the content of EuiFlyoutHeader

Before

76809805-384e2200-67a9-11ea-8d31-4ebe3829ad0e

After

image

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
    - [ ] Props have proper autodocs
    - [ ] Added documentation examples
    - [ ] Added or updated jest tests
    - [ ] Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@andreadelrio andreadelrio requested a review from snide March 17, 2020 00:21
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3098/

@cchaos
Copy link
Contributor

cchaos commented Mar 17, 2020

I also un-strike-throughed a couple of checklist items that, even though it's a small change, should get double-checked "just in case".

@andreadelrio andreadelrio requested a review from cchaos March 17, 2020 17:09
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3098/

cchaos
cchaos approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, thank you for fixing this one. I saw the screenshots in the Kibana PR, and thought to myself "That alignment is gonna irk me". 😆

@andreadelrio andreadelrio merged commit e57b111 into elastic:master Mar 17, 2020
@chandlerprall chandlerprall mentioned this pull request Mar 31, 2020
Closed
@chandlerprall chandlerprall mentioned this pull request Apr 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

@snide snide Awaiting requested review from snide

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreadelrio @kibanamachine @cchaos