EuiButton, EuiButtonEmpty and EuiButtonIcon can now take an HREF #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
suggested changes
Jan 18, 2018
CHANGELOG.md
Outdated
| @@ -1,6 +1,10 @@ | |||
| # [`master`](https://github.com/elastic/eui/tree/master) | |||
|
|
|||
| No public interface changes since `0.0.13`. | |||
| - EuiButton, EuiButtonEmpty and EuiButtonIcon can now take an HREF [(#316)](https://github.com/elastic/eui/pull/316) | |||
There was a problem hiding this comment.
Small nit: can we change "HREF" to be:
`href`
(using back ticks for code-formatting)
src/components/button/button.js
Outdated
| @@ -32,6 +33,15 @@ const iconSideToClassNameMap = { | |||
|
|
|||
| export const ICON_SIDES = Object.keys(iconSideToClassNameMap); | |||
|
|
|||
| // const checkHrefAndOnClick = (props, propName, componentName) => { | |||
There was a problem hiding this comment.
"Kiiiiillll... meeeeee......" - this code
src/components/button/button.js
Outdated
| if (href) { | ||
| return ( | ||
| <a | ||
| disabled={isDisabled} |
There was a problem hiding this comment.
According to googles, disabled isn't a valid attribute on anchor tags.
| if (href) { | ||
| return ( | ||
| <a | ||
| disabled={isDisabled} |
| if (href) { | ||
| return ( | ||
| <a | ||
| disabled={isDisabled} |
|
Feedback addressed. Gonna wait for tests to pass then I'll merge. |
|
jenkins, test this |
|
Looks like we're still having build problems on github. Merging this though because it's fairly simple / tested locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24
Used a pattern @cjcenizal used in KUI. Moved the function to a new folder of
/services/prop-types/since we'll likely have more of these kind of reusable prop checks in the future.