-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiSelectable] Fix focus management bug #4152
Conversation
Preview documentation changes for this PR: https://eui.elastic.co/pr_4152/ |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4152/ |
Has anyone also verified that this fixes the issue in Kibana? |
@cchaos Confirmed in Kibana this PR solves the issues over there. Good call. |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4152/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changelog nit, otherwise this LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix @myasonik ! Tested on the docs site, and the implementation where I saw it before is fixed now. Just a comment about the CL.
@chandlerprall Should this get a backport for Kibana 7.10?
Works for me, seems worth getting ahead of instead of waiting for someone to notice & ask. |
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Preview documentation changes for this PR: https://eui.elastic.co/pr_4152/ |
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Summary
Fixes #4128 and fixes #4147
1000 points to @chandlerprall for helping hunt down this fix
Checklist
Check against all themes for compatibility in both light and dark modesChecked in mobileProps have proper autodocsAdded documentationChecked Code Sandbox works for the any docs examplesAdded or updated jest tests