Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiSelectable] Fix focus management bug #4152

Merged
merged 5 commits into from
Oct 19, 2020

Conversation

myasonik
Copy link
Contributor

@myasonik myasonik commented Oct 16, 2020

Summary

Fixes #4128 and fixes #4147

1000 points to @chandlerprall for helping hunt down this fix

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs
  • Added documentation
  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4152/

@myasonik
Copy link
Contributor Author

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4152/

@cchaos
Copy link
Contributor

cchaos commented Oct 19, 2020

Has anyone also verified that this fixes the issue in Kibana?

@myasonik
Copy link
Contributor Author

@cchaos Confirmed in Kibana this PR solves the issues over there. Good call.

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4152/

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changelog nit, otherwise this LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @myasonik ! Tested on the docs site, and the implementation where I saw it before is fixed now. Just a comment about the CL.

@chandlerprall Should this get a backport for Kibana 7.10?

CHANGELOG.md Outdated Show resolved Hide resolved
@chandlerprall
Copy link
Contributor

@chandlerprall Should this get a backport for Kibana 7.10?

Works for me, seems worth getting ahead of instead of waiting for someone to notice & ask.

Michail Yasonik and others added 2 commits October 19, 2020 14:12
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4152/

@myasonik myasonik merged commit 9e028d8 into elastic:master Oct 19, 2020
@myasonik myasonik deleted the fix-searchable-dbl-click branch October 19, 2020 20:35
kshitij86 added a commit to kshitij86/eui that referenced this pull request Nov 29, 2020
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants