Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiStep(s)Horizontal] Add HTML element type extensions #4166

Merged
merged 4 commits into from
Oct 27, 2020
Merged

[EuiStep(s)Horizontal] Add HTML element type extensions #4166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0445082
add htmlbuttonelment type extension
thompsongl Oct 21, 2020
fa6f52d
add htmlolistelment type extension
thompsongl Oct 21, 2020
835b959
CL
thompsongl Oct 21, 2020
a9214b0
Merge branch 'master' into 4164-step
thompsongl Oct 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
**Bug fixes**

- Fixed issue with duplicate checkmarks in `EuiComboBox` ([#4162](https://github.com/elastic/eui/pull/4162))
- Reinstated base element type extensions for `EuiStepHorizontal` and `EuiStepsHorizontal` ([4166](https://github.com/elastic/eui/pull/4166))

## [`30.0.0`](https://github.com/elastic/eui/tree/v30.0.0)

Expand Down
5 changes: 4 additions & 1 deletion src/components/steps/step_horizontal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

import classNames from 'classnames';
import React, {
ButtonHTMLAttributes,
FunctionComponent,
MouseEvent as ReactMouseEvent,
MouseEventHandler,
Expand All @@ -33,7 +34,9 @@ import {
useI18nWarningStep,
} from './step_strings';

export interface EuiStepHorizontalProps extends CommonProps {
export interface EuiStepHorizontalProps
extends Omit<ButtonHTMLAttributes<HTMLButtonElement>, 'onClick'>,
CommonProps {
/**
* Is the current step
*/
Expand Down
6 changes: 4 additions & 2 deletions src/components/steps/steps_horizontal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,13 @@
*/

import classNames from 'classnames';
import React, { FunctionComponent } from 'react';
import React, { FunctionComponent, OlHTMLAttributes } from 'react';
import { CommonProps } from '../common';
import { EuiStepHorizontal, EuiStepHorizontalProps } from './step_horizontal';

export interface EuiStepsHorizontalProps extends CommonProps {
export interface EuiStepsHorizontalProps
extends OlHTMLAttributes<HTMLOListElement>,
CommonProps {
/**
* An array of `EuiStepHorizontal` objects excluding the `step` prop
*/
Expand Down