[EuiDataGrid] Fix stripes incorrectly alternating on sort/pagination #5070
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5070/ |
|
Per our discussion at sync today, I'm going to be writing shallow unit tests for all DataGrid child components this week. As such I'm going to hold off on merging this PR/revert it to draft mode until there's unit tests for this bug that I can update. |
cee-chen
force-pushed
the
datagrid-stripes
branch
from
1b08dee
to
661c20a
Compare
|
@thompsongl 👋 Here's the unit tests I ended up writing specifically for
|
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5070/ |
|
Sweeet! Thanks for the master merge! 🙏 |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5070/ |
Summary
closes #4705
Apologies if the striping is hard to see on my recorded gif settings! 🙈
Before
After
Checklist
This is a fairly straightforward JS fix, so I opted not to thoroughly frontend test it. I'm also 50/50 on adding unit tests for this fix; if we didn't have unit tests already written for striping I'm not a massive fan of adding ones now for a primarily visual bugfix, but I can do so if folks feel strongly about it!
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in Chrome, Safari, Edge, and Firefox- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes