[EuiDescriptionList] titleProps and descriptionProps extends CommonProps

[MukulKolpe]

Fixes #5148

EuiDescriptionListProps is extending CommonProps.

Checklist

~- [ ] Check against all themes for compatibility in both light and dark modes
~- [ ] Checked in mobile
~- [ ] Checked in Chrome, Safari, Edge, and Firefox

• Props have proper autodocs and playground toggles

~- [ ] Added documentation
~- [ ] Checked Code Sandbox works for any docs examples

• Added or updated jest tests

~- [ ] Checked for breaking changes and labeled appropriately
~- [ ] Checked for accessibility including keyboard-only and screen reader modes

• A changelog entry exists and is marked appropriately

[cla-checker-service]

💚 CLA has been signed

[kibanamachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[thompsongl]

Hey thanks, @MukulKolpe!

Can you please sign the CLA if you haven't already?

[MukulKolpe]

I signed it actually

[thompsongl]

Also, @MukulKolpe, be sure to check off or cross out all checklist items. For instance, this PR will require a changelog entry.

[cchaos]

I've also unchecked the PR checklist item about jest tests. We should add a specific test for passing the requiredProps to each of these props in https://github.com/elastic/eui/blob/588df390546fc7439ae1cdefcd09cfe192117002/src/components/description_list/description_list.test.tsx.

For example, in that file, if you move the const listItems = [...] to outside of the testing block to reuse, then you can add something like:

  describe('titleProps', () => {
      test('is rendered', () => {
        const component = render(<EuiDescriptionList listItems={listItems} titleProps={requiredProps} />);

        expect(component).toMatchSnapshot();
      });
    });

[thompsongl]

jenkins test this

[MukulKolpe]

Hey, why was this build failing?
and should I write unit tests here ?
https://github.com/elastic/eui/blob/588df390546fc7439ae1cdefcd09cfe192117002/src/components/description_list/description_list.test.tsx

[cchaos]

That was just a failed run. And yes, that is the file to add the tests too. After adding them, be sure to run yarn test-unit -u to update/create the snapshots. Once you'd pushed those changes we can re-run CI.

[cchaos]

Jenkins, test this

[kibanamachine]

Preview documentation changes for this PR: https://eui.elastic.co/pr_5166/

[thompsongl]

jenkins test this

[kibanamachine]

Preview documentation changes for this PR: https://eui.elastic.co/pr_5166/

[cchaos]

👍 LGTM! Thanks for the PR @MukulKolpe

[MukulKolpe]

Thank you @thompsongl and @cchaos for helping me with this issue!!

[thompsongl]

Thanks, @MukulKolpe!