Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump typescript version to ~4.1.3 #5182

Merged
merged 2 commits into from
Sep 14, 2021

Conversation

chandlerprall
Copy link
Contributor

@chandlerprall chandlerprall commented Sep 14, 2021

Summary

Breaking change

Closes #5146 by upgrading our typescript dependency to match Kibana's pinned version.

  • updated TS version in dependencies & peerDependencies
  • gave a Promise in icon.test.txt an explicit return type
  • convinced TS spreading searchProps in *EuiSelectableSitewideTemplate is okay
  • tested resulting eui.d.ts in Kibana

Checklist

- [ ] Check against all themes for compatibility in both light and dark modes
- [ ] Checked in mobile
- [ ] Checked in Chrome, Safari, Edge, and Firefox
- [ ] Props have proper autodocs and playground toggles
- [ ] Added documentation
- [ ] Checked Code Sandbox works for any docs examples
- [ ] Added or updated jest tests

  • Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5182/

Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is much cleaner than I expected 🦑

@chandlerprall chandlerprall merged commit c56a529 into elastic:master Sep 14, 2021
@chandlerprall chandlerprall deleted the 5146/upgrade-typescript branch September 14, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Deps] Pin typescript to ~ not ^
3 participants