[EuiTour] Style and a11y fixes #5225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 29, 2021 16:47
And instead maps directly to `CSSProperties[‘minWidth’]` and applies it directly to `panelStyle`. Also adds `maxWidth` option.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5225/ |
5 tasks
miukimiu
approved these changes
Sep 30, 2021
There was a problem hiding this comment.
LGTM! 🎉
+1 for making the subtitle optional. Tested locally in Chrome, Safari, Edge, and Firefox.
All the tests snapshots don't look good to me. Even old ones like EuiTourStep can be closed. I added some suggestions to fix the new tests that you added but I'm not a specialist. So maybe @thompsongl can take a look.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5225/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5112 and closes #4843
Made
subtitleoptionalI ran into this where I wanted to use the EuiTour component more to indicate to users changes in the UI, so it wasn't more than a single step. Requiring two titles and body content was quite excessive. So I just made
subtitleoptional.Fixed the
footerbackground from extending beyond the popover boundsBefore
After
🔔 [Breaking] Changed how
minWidthwas applied and addedmaxWidthBefore, it was accepting a boolean, number or string and doing some className workarounds for the default of
true. I noticed that this wasn't actually working (the default minWidth class was never getting applied) and so I just changed the type toCSSProperties['minWidth']set the default to300and passed it along topanelStyle.I also then added a similar thing for
maxWidth.Lowered the heading levels
They started at
<h1>, but as per the guidance in #4843 , they should start ath2.Checklist