Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy src json file to build outputs #6172

Merged
merged 3 commits into from
Aug 24, 2022

Conversation

chandlerprall
Copy link
Contributor

@chandlerprall chandlerprall commented Aug 24, 2022

Summary

Fixes #6171

Updated the build process to copy src/**/*.json files into each of the builds. Tested this in a fresh create react app; used v65.0.1 to verify failure and then pointed the app at a local eui build containing this fix.

Verified the files were copied as expected:

% find . -name logicals.json
./optimize/lib/global_styling/functions/logicals.json
./optimize/es/global_styling/functions/logicals.json
./test-env/global_styling/functions/logicals.json
./lib/global_styling/functions/logicals.json
./es/global_styling/functions/logicals.json
./src/global_styling/functions/logicals.json

Checklist

- [ ] Checked in both light and dark modes
- [ ] Checked in mobile
- [ ] Checked in Chrome, Safari, Edge, and Firefox
- [ ] Props have proper autodocs and playground toggles
- [ ] Added documentation
- [ ] Checked Code Sandbox works for any docs examples
- [ ] Added or updated jest and cypress tests

  • Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
    - [ ] Updated the Figma library counterpart
  • A changelog entry exists and is marked appropriately

Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed with a local build that the JSON files are in the right asset location

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6172/

Copy link
Contributor

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@chandlerprall chandlerprall merged commit f349b2e into elastic:main Aug 24, 2022
@chandlerprall chandlerprall deleted the bug/json-src-files branch August 24, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing from versions 65.0.0 and 65.0.1 do not work
4 participants