Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiListGroupItem] Add Tooltip text prop #6186

Merged
merged 5 commits into from
Aug 29, 2022

Conversation

spzala19
Copy link
Contributor

@spzala19 spzala19 commented Aug 27, 2022

Summary

closes #6114
Added optional tooltipText prop in EuiListGroupItem component. It'll enable developers to provide custom tooltip text. By default, the tooltip will have the text same as the label text.

Checklist

  • Checked by providing tooltipText prop
  • Checked without providing tooltipText prop
  • Updated Documentation for this component
  • Added changelog entry

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@spzala19 spzala19 changed the title Tooltip text eui list group item [EuiListGroupItem] Add Tooltip text prop Aug 27, 2022
@thompsongl
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6186/

@thompsongl
Copy link
Contributor

jenkins test this

@thompsongl thompsongl enabled auto-merge (squash) August 29, 2022 19:37
@thompsongl
Copy link
Contributor

Thanks, @spzala19! So nice when our community folks help out and make reviews easy on the team!

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6186/

@thompsongl
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6186/

@thompsongl thompsongl merged commit 0ca5f5b into elastic:main Aug 29, 2022
</p>
<>
<p>
Similarly, <EuiCode>toolTipText</EuiCode> can be used to provide
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thompsongl I think, here the lines removed/edited incorrectly by you. Maybe you meant to just improve what I added

What I added,

         <p>
            <EuiCode>toolTipText</EuiCode> can
            be also used to provide tooltip text. By default, the tooltip will
            have the text same as <EuiCode>label</EuiCode> text.
          </p>

Your suggestion,

         <p>
            Similarly, ...rest is same as above ...
          </p>

Mistakenly you removed the wrong block an duplicated the same paragraph. I know the PR is already merged but we will need to fix this if it's not intentional right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep you're right. 🤦‍♂️ I'll fix it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an optional 'tootipText' property to EuiListGroupItem so that the text of the tooltip can be overridden
3 participants