-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiListGroupItem] Add Tooltip text prop #6186
[EuiListGroupItem] Add Tooltip text prop #6186
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_6186/ |
jenkins test this |
Thanks, @spzala19! So nice when our community folks help out and make reviews easy on the team! |
Preview documentation changes for this PR: https://eui.elastic.co/pr_6186/ |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_6186/ |
</p> | ||
<> | ||
<p> | ||
Similarly, <EuiCode>toolTipText</EuiCode> can be used to provide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thompsongl I think, here the lines removed/edited incorrectly by you. Maybe you meant to just improve what I added
What I added,
<p>
<EuiCode>toolTipText</EuiCode> can
be also used to provide tooltip text. By default, the tooltip will
have the text same as <EuiCode>label</EuiCode> text.
</p>
Your suggestion,
<p>
Similarly, ...rest is same as above ...
</p>
Mistakenly you removed the wrong block an duplicated the same paragraph. I know the PR is already merged but we will need to fix this if it's not intentional right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep you're right. 🤦♂️ I'll fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
closes #6114
Added optional
tooltipText
prop inEuiListGroupItem
component. It'll enable developers to provide custom tooltip text. By default, the tooltip will have the text same as the label text.Checklist
tooltipText
proptooltipText
prop