Fix various nested componentProps to accept the css prop type
#6211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- to do so, they need to explicitly extend CommonProps
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6211/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#6118 extended
CommonPropsto allow thecssEmotion prop for Emotion-based styling, but not all nested*Propswere correctly extending CommonProps. I did a quick grep forProps?:and checked for types that were not extending CommonProps.The second commit of this PR addresses #6074 (comment) (figured I'd grab that while I was here).
Checklist
As this is not a change that affects end-users, I'm not 100% sure if we need a changelog for this, but including in any case