-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiAccordion] Remove will-change
CSS
#6235
Conversation
Preview documentation changes for this PR: https://eui.elastic.co/pr_6235/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_6235/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change LGTM, tested the accordion examples across browsers and don't see any difference
…accordion" This reverts commit 052e679.
Preview documentation changes for this PR: https://eui.elastic.co/pr_6235/ |
Summary
EuiAccordion's
will-change
CSS creates a stacking context which causes nested positioned components to behave unexpectedly, e.g. fullscreen mode in EuiDataGrid:We're opting removing this CSS for several reasons:
translateZ
withwill-change
#5806:transform: translatez(0);
was a preoptimization. In that case, we can removewill-change
, too"translateZ
was first added by 5 years ago in a relatively unrelated component PR, so we're guessing the addition this was an unnecessary pre-optimization that was popular in the frontend world at the timewill-change
is intended to be used as a last resort, in order to try to deal with existing performance problems. It should not be used to anticipate performance problems"QA
Checklist