-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for validation to EuiComboBox and fix some bugs #631
Conversation
… refining the focus and blur logic.
…y the absolute position in the CSS.
z-index: $euiZComboBox; | ||
position: absolute; | ||
position: fixed; /* 2 */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@snide Do you see any problem with this changing to fixed
? Is there a reason it needs to be absolute
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens when you scroll the page? Fixed normally breaks in that situation if it's open unless you are constantly calculating it on scroll.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We update the position as the user scrolls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you're constantly calculating so you should be ok. Lemme double check on IE11 though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do some more review tonight, but off-hand I think this works fine. Checked the other browsers as well.
@snide Thanks for taking a look. That scroll lag in IE11 is pretty gnarly. I figured out a way to fix the original bug using |
…rove performance, particularly on IE11.
1cb688c
to
9ad1c82
Compare
@cjcenizal Think that brought in a new issue. FWIW this looks like a similar problem to the calc on master, where |
@snide Is |
@cjcenizal nope. for some reason your style top value doesn't get calculated. This is the same issue I noticed on #610, so my guess is that it has to do with |
This reverts commit c8a3116.
No description provided.