Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove overflow: hidden from EuiModal styles that caused a red overla… #6343

Merged
merged 5 commits into from
Nov 3, 2022
Merged

Remove overflow: hidden from EuiModal styles that caused a red overla… #6343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9a3ad40
Remove overflow: hidden from EuiModal styles that caused a red overla…
breehall Nov 3, 2022
d4c455a
CHANGELOG
breehall Nov 3, 2022
4d521d5
Update upcoming_changelogs/6343.md
breehall Nov 3, 2022
e1efb16
Update upcoming_changelogs/6343.md
breehall Nov 3, 2022
4097c5a
Restore overflow:hidden in the form of a comment to reconsider once t…
breehall Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/components/modal/_modal.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
display: flex;
flex-direction: column;
max-height: 75vh; // We overflow the modal body based off this
overflow: hidden; // Ensure long, non-breaking text doesn't expand beyond the modal bounds
cee-chen marked this conversation as resolved.
Show resolved Hide resolved

// TODO: Consider restoring this once https://bugs.chromium.org/p/chromium/issues/detail?id=1229700 is resolved
// overflow: hidden; Ensure long, non-breaking text doesn't expand beyond the modal bounds

position: relative;
background-color: $euiColorEmptyShade;
Expand Down
3 changes: 3 additions & 0 deletions upcoming_changelogs/6343.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
**Bug fixes**

- Fixed a webkit rendering issue with `EuiModal`s containing `EuiBasicTable`s tall enough to scroll