Add support for nodes as a proptype for errors. #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
suggested changes
Apr 18, 2018
CHANGELOG.md
Outdated
| @@ -1,6 +1,7 @@ | |||
| ## [`master`](https://github.com/elastic/eui/tree/master) | |||
|
|
|||
| - Added `status` prop to `EuiStep` for additional styling ([#673](https://github.com/elastic/eui/pull/673)) | |||
| - Add support for node as a proptype for EuiForm and EuiFormRow errors. ([#685](https://github.com/elastic/eui/pull/685)) | |||
There was a problem hiding this comment.
Could we change the note to this? (wrapped the component names in backticks and made the note a bit terser)
`EuiForm` and `EuiFormRow` now accept nodes for `errors` prop
src/components/form/form.js
Outdated
| @@ -54,5 +54,5 @@ export const EuiForm = ({ | |||
|
|
|||
| EuiForm.propTypes = { | |||
| isInvalid: PropTypes.bool, | |||
| error: PropTypes.oneOfType([PropTypes.string, PropTypes.arrayOf(PropTypes.string)]), | |||
| error: PropTypes.oneOfType([PropTypes.string, PropTypes.arrayOf(PropTypes.string), PropTypes.node]), | |||
There was a problem hiding this comment.
We can simplify this a bit, since node is a blanket propType which accepts strings, elements, and arrays:
error: PropTypes.oneOfType([PropTypes.node, PropTypes.arrayOf(PropTypes.node)]),| @@ -150,7 +150,7 @@ EuiFormRow.propTypes = { | |||
| label: PropTypes.node, | |||
| id: PropTypes.string, | |||
| isInvalid: PropTypes.bool, | |||
| error: PropTypes.oneOfType([PropTypes.string, PropTypes.arrayOf(PropTypes.string)]), | |||
| error: PropTypes.oneOfType([PropTypes.string, PropTypes.arrayOf(PropTypes.string), PropTypes.node]), | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been getting a few of these warnings while running tests in Cloud.
They're being caused because the error passed is a node (rather than the currently accepted string or array of strings. I spoke to @pugnascotia and @cjcenizal who agreed that we should allow node as a PropType too.