[A11y] Fixed two failing Cypress accessibility tests #7029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_7029/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_7029_buildkite/ |
💚 Build Succeeded
cc @1Copenut |
breehall
approved these changes
Aug 2, 2023
Great question! These tests don't currently run as part of our CI job because they have a significant overhead. My plan is to start running them again as a nightly job after we get the Buildkite migration completed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Two tests were failing because of changes to an
aria-labeland a containing CSS class. I updated these and re-ran the tests locally.This PR closes #7024.
QA
Ran tests locally several times in CI (headless) mode and using the Cypress UI. All tests passing again.
General checklist