Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade chroma-js to 2.4.2 #7039

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

tkajtoch
Copy link
Member

@tkajtoch tkajtoch commented Aug 7, 2023

Summary

This PR resolves Snyk dependency upgrade recommendation from #6799 by upgrading chroma-js and @types/chroma-js to their latest versions.

chroma-js changelog diff

QA

  • (chroma.mix) Open <EuiBottomBar /> component docs, open the bottom bar and make sure the background color is rgb(19, 19, 23)

  • (chroma.hsv) Ensure <EuiColorPicker /> HSV color selection in prod and PR environment results in the same colors.

  • (chroma.scale) Open <EuiColorPicker />, scroll down to Stepped color segments and ensure the background CSS property value for its euiRangeHighlightProgress test subject is:

    See value

    linear-gradient(to right, transparent 19%, rgb(84, 179, 153) 19%, rgb(84, 179, 153) 23.28%, rgb(105, 165, 150) 23.28%, rgb(105, 165, 150) 27.56%, rgb(126, 151, 147) 27.56%, rgb(126, 151, 147) 31.84%, rgb(148, 138, 144) 31.84%, rgb(148, 138, 144) 36.12%, rgb(169, 124, 140) 36.12%, rgb(169, 124, 140) 40.4%, rgb(190, 110, 137) 40.4%, rgb(190, 110, 137) 44.68%, rgb(211, 96, 134) 44.68%, rgb(211, 96, 134) 48.96%, rgb(189, 101, 151) 48.96%, rgb(189, 101, 151) 53.24%, rgb(167, 107, 167) 53.24%, rgb(167, 107, 167) 57.52%, rgb(145, 112, 184) 57.52%, rgb(145, 112, 184) 61.8%)

General checklist

  • Checked in Chrome, Safari, Edge, and Firefox

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_7039/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_7039_buildkite/

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @tkajtoch

Copy link
Contributor

@1Copenut 1Copenut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM! I retested your QA steps in Chrome on the Buildkite preview. All colors matched exactly.

@tkajtoch tkajtoch merged commit 52565f7 into elastic:main Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants