[Emotion] Document usage of getters in Emotion style objects #7104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
added
documentation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_7104/ |
💚 Build Succeeded
|
1Copenut
approved these changes
Aug 21, 2023
|
🎉 Thanks a million Trevor! Glad to hear you're a fan of the syntax! |
|
@breehall, I'm going to go ahead and merge, but feel free to leave a comment if you have any change requests for the documentation. I'm more than happy to open up a follow-up PR |
breehall
reviewed
Aug 21, 2023
| @@ -262,6 +262,30 @@ Although possible in some contexts, it is not recommended to "shortcut" logic us | |||
| `${font.body.letterSpacing ? `letter-spacing: ${font.body.letterSpacing}` : ''`}` | |||
| ``` | |||
|
|
|||
| ## Duplicate styles | |||
There was a problem hiding this comment.
Thank you for the guidelines and example!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a follow-up to #7091 (comment) which was the first PR/component to use getters in Emotion. I've decided to document the approach and update our
EuiSteps styles to adopt it as well.QA
mandssized steps have the same alignmentGeneral checklist
[ ] A changelog entry exists and is marked appropriately- Skipping as this should not affect consumers or end-users