Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiComboBox] Update to dogfood EuiInputPopover #7246

Merged
merged 12 commits into from
Oct 5, 2023
Merged

[EuiComboBox] Update to dogfood EuiInputPopover #7246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
679bdbe
Update EuiComboBox to dogfood EuiInputPopover
cee-chen Sep 30, 2023
e396a68
Remove now unnecessary update position logic
cee-chen Sep 30, 2023
2d85f3c
Remove now-unnecessary z-index logic
cee-chen Sep 30, 2023
7e0cdc2
Move `closeOnScroll` logic to EuiInputPopover
cee-chen Oct 1, 2023
a5c6554
Remove now-unnecessary width state
cee-chen Oct 1, 2023
bd8df8b
Clean up further unnecessary list refs
cee-chen Oct 1, 2023
8897ff4
Remove even more unused/vestigial code
cee-chen Oct 1, 2023
3ac62a3
[nit/cleanup] optional chaining syntax
cee-chen Oct 1, 2023
f374ee3
[SPICY POTATO] Remove logic that apparently only exists for React 16.3
cee-chen Oct 1, 2023
2e36462
T E S T S
cee-chen Oct 1, 2023
d50c5f8
🎺 Add `inputPopoverProps` support 🎺
cee-chen Oct 1, 2023
3cee693
changelog
cee-chen Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src-docs/src/views/popover/input_popover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ export default () => {
<EuiInputPopover
isOpen={isPopoverOpen}
closePopover={() => setIsPopoverOpen(false)}
closeOnScroll={true}
input={
<EuiFieldText
onFocus={() => setIsPopoverOpen(true)}
Expand Down
Loading