Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Emotion] Convert EuiContextMenu, EuiContextMenuPanel, and EuiContextMenuItem #7312

Merged
merged 25 commits into from
Oct 25, 2023
Merged

[Emotion] Convert EuiContextMenu, EuiContextMenuPanel, and EuiContextMenuItem #7312

merged 25 commits into from
Oct 25, 2023

Commits on Oct 24, 2023

  1. [EuiContextMenu] Set up basic styles file + HOC + variables

    @cee-chen
    cee-chen committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    81a84ad View commit details
    Browse the repository at this point in the history

  2. [EuiContextMenu] Convert more Sass to Emotion

    @cee-chen
    cee-chen committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    0aed518 View commit details
    Browse the repository at this point in the history

  3. Delete unused .euiContextMenu__content selector 

    - not used anwhere as in either EUI or Kibana
    @cee-chen
    cee-chen committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    1464c26 View commit details
    Browse the repository at this point in the history

  4. Convert child __panel styles 

    - inline it since it's pretty basic
    @cee-chen
    cee-chen committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    3ae4924 View commit details
    Browse the repository at this point in the history

  5. Convert margin CSS to flex gap

    @cee-chen
    cee-chen committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    2d4fecc View commit details
    Browse the repository at this point in the history

  6. [EuiContextMenuPanel] Set up Emotion file + HOC

    @cee-chen
    cee-chen committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    5a31e89 View commit details
    Browse the repository at this point in the history

  7. Convert panel transitions/animations to Emotion 

    + remove unused `--next`/`--previous` classes
    @cee-chen
    cee-chen committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    353179b View commit details
    Browse the repository at this point in the history

  8. [EuiContextMenuPanel] Convert title Sass to Emotion

    @cee-chen
    cee-chen committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    0e63a1a View commit details
    Browse the repository at this point in the history

  9. [EuiContextMenuItem] Convert to function component

    @cee-chen
    cee-chen committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    84a452d View commit details
    Browse the repository at this point in the history

  10. [EuiContextMenuItem] Set up Emotion file + basic styles

    @cee-chen
    cee-chen committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    c2a7ec7 View commit details
    Browse the repository at this point in the history

  11. DRY out shared padding sizes

    @cee-chen
    cee-chen committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    b145539 View commit details
    Browse the repository at this point in the history

  12. [EuiContextMenuItem] Convert more styles to Emotion

    @cee-chen
    cee-chen committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    53c9d3a View commit details
    Browse the repository at this point in the history

  13. [EuiContextMenuItem] Remove unnecessary __itemLayout div wrapper

    @cee-chen
    cee-chen committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    b701691 View commit details
    Browse the repository at this point in the history

  14. [cleanup] Fix broken styles + DRY out repeated CSS on `EuiContextMenu… 

    …PanelTitle`

- by dogfooding `EuiContextMenuItem`

- this requires updating `EuiContextMenuItem`'s logic to be able to render a `div` if necessary

- we can now remove the `padding` variables, since `EuiContextMenuItem` is now the only one that uses it
    @cee-chen
    cee-chen committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    ed80b82 View commit details
    Browse the repository at this point in the history

  15. [docs] Fix docs examples without onClicks 

    - due to the previous change, they'd otherwise render as `div`s and not register within the tab order
    @cee-chen
    cee-chen committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    e5ec89c View commit details
    Browse the repository at this point in the history

  16. [EuiContextMenuItem] Convert remaining child styles to Emotion 

    + syntax cleanup - prefer `const` and `&&` over `let` and `if`
    @cee-chen
    cee-chen committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    a8a0e70 View commit details
    Browse the repository at this point in the history

  17. [EuiContextMenu] Remove now unused size className modifiers 

    - we're applying these styles directly via Emotion in the child components instead of at the parent
    @cee-chen
    cee-chen committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    a6ede35 View commit details
    Browse the repository at this point in the history

  18. Delete Sass files

    @cee-chen
    cee-chen committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    6cc7b48 View commit details
    Browse the repository at this point in the history

  19. Update tests 

    - add `shouldRenderCustomStyles`

- convert all tests to RTL

- convert snapshots to assertions where it makes sense to do so
    @cee-chen
    cee-chen committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    1a23a45 View commit details
    Browse the repository at this point in the history

  20. Update downstream snapshots

    @cee-chen
    cee-chen committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    39d39aa View commit details
    Browse the repository at this point in the history

  21. Fix Cypress tests 

    - Fix class assertion failures caused by new Emotion classes (convert `have.attr, class`->`have.class`)

- Fix focus failures caused by items without `href`s or `onClick`s rendering as `div`s
    @cee-chen
    cee-chen committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    fd238d5 View commit details
    Browse the repository at this point in the history

  22. [EuiContextMenuItem] Fix height change caused by euiFontSize line h… 

    …eight change
    @cee-chen
    cee-chen committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    e1f9cac View commit details
    Browse the repository at this point in the history

  23. changelog

    @cee-chen
    cee-chen committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    3486c4b View commit details
    Browse the repository at this point in the history

  24. [docs] Test that context menus within EuiBottomBars are no longer vis… 

    …ually broken
    @cee-chen
    cee-chen committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    fc5f630 View commit details
    Browse the repository at this point in the history

  25. [EuiContextMenu] Add missing reduced motion affordance 

    - due to the way the component is currently set up with `onAnimationEnd`, setting a 0s animation duration is the easiest way to reduce motion
    @cee-chen
    cee-chen committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    7c2c46f View commit details
    Browse the repository at this point in the history