Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update requiresAriaLabel custom proptype and its usages #802

Merged
merged 2 commits into from
May 8, 2018
Merged

update requiresAriaLabel custom proptype and its usages #802

merged 2 commits into from
May 8, 2018

Conversation

chandlerprall
Copy link
Contributor

Updates the requiresAriaLabel proptype to be passed the name of its action property only, as the label property is already associated from the propname.

Also fixes its usage on Badge.

@chandlerprall chandlerprall requested a review from snide May 7, 2018 21:42
snide
snide approved these changes May 7, 2018
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY

@chandlerprall chandlerprall merged commit 91d4f0a into elastic:master May 8, 2018
@chandlerprall chandlerprall deleted the update-aria-label-proptype branch May 8, 2018 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snide snide snide approved these changes

Assignees
No one assigned
Labels
accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chandlerprall @snide