-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(code_block): remove all snapshot tests and redundant describe blocks #8185
Open
weronikaolejniczak
wants to merge
12
commits into
elastic:main
Choose a base branch
from
weronikaolejniczak:refactor/8180-refactor-code-block-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9cb1e61
feat(code_block): allow for a custom copy button aria-label
weronikaolejniczak 0ccfd50
refactor(code_block): rename copyAriaLabel and remove docs
weronikaolejniczak dbeb3be
chore: update the changelog
weronikaolejniczak acc44d3
refactor(code_block): improve the copyAriaLabel test case
weronikaolejniczak 950d663
refactor(code_block): remove all snapshot tests and redundant describ…
weronikaolejniczak d6ae46c
chore(code_block): add VRT tests for the EuiCodeBlock
weronikaolejniczak 014385a
chore(code_block): remove duplicated copyright comment
weronikaolejniczak 9299032
chore(code_block): remove VRT tests
weronikaolejniczak 6b5bc29
chore(code_block): improve the unit test suite
weronikaolejniczak 32ac68d
Merge branch 'main' into refactor/8180-refactor-code-block-tests
weronikaolejniczak 3294750
chore(code_block): use toHaveStyleRule and test.each
weronikaolejniczak 969214e
chore: remove old changelog file
weronikaolejniczak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file added
BIN
+4.62 KB
.../eui/.loki/reference/chrome_desktop_Editors_Syntax_EuiCodeBlock_Annotations.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+4.24 KB
...loki/reference/chrome_desktop_Editors_Syntax_EuiCodeBlock_Highlighted_Lines.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+4.34 KB
.../eui/.loki/reference/chrome_desktop_Editors_Syntax_EuiCodeBlock_Start_Value.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+8.96 KB
...s/eui/.loki/reference/chrome_mobile_Editors_Syntax_EuiCodeBlock_Annotations.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+8.13 KB
....loki/reference/chrome_mobile_Editors_Syntax_EuiCodeBlock_Highlighted_Lines.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+8.39 KB
...s/eui/.loki/reference/chrome_mobile_Editors_Syntax_EuiCodeBlock_Start_Value.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
807 changes: 22 additions & 785 deletions
807
packages/eui/src/components/code/__snapshots__/code_block.test.tsx.snap
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦 Thank you so much for catching this!