Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test enrollment_api_key_integration_test.go:113 #1289

Closed
ph opened this issue Apr 1, 2022 · 2 comments
Closed

Flaky test enrollment_api_key_integration_test.go:113 #1289

ph opened this issue Apr 1, 2022 · 2 comments
Labels
8.5-candidate flaky-test Unstable or unreliable test cases. Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Comments

@ph
Copy link
Contributor

ph commented Apr 1, 2022 •
edited
Loading

Flaky Test

  • Notes:
    Looking at the diff and the code it's one of the following:
  • The return of the values from Elastic is not deterministic, maybe not sorting
  • Do the code require the values to be always return in the right order?

Found in #1287

Where unrelated code was touched, rekicking the ci and the test was green again.

Stack Trace

[2022-04-01T13:17:50.735Z]     enrollment_api_key_integration_test.go:113:   []model.EnrollmentApiKey{
[2022-04-01T13:17:50.735Z]           	{
[2022-04-01T13:17:50.735Z]           		ESDocument: model.ESDocument{
[2022-04-01T13:17:50.735Z]         - 			Id:      "c93fmvc2jgjfauojood0",
[2022-04-01T13:17:50.735Z]         + 			Id:      "c93fmvc2jgjfauojooe0",
[2022-04-01T13:17:50.735Z]           			Version: 0,
[2022-04-01T13:17:50.735Z]           			SeqNo:   0,
[2022-04-01T13:17:50.735Z]           		},
[2022-04-01T13:17:50.735Z]           		Active:    true,
[2022-04-01T13:17:50.735Z]           		ApiKey:    "d2JndlFIWUJJUVVxWDVia2NJTV86X0d6ZmljZGNTc1d4R1otbklrZFFRZw==",
[2022-04-01T13:17:50.735Z]         - 		ApiKeyId:  "c93fmvc2jgjfauojoodg",
[2022-04-01T13:17:50.735Z]         + 		ApiKeyId:  "c93fmvc2jgjfauojooeg",
[2022-04-01T13:17:50.735Z]           		CreatedAt: "2022-04-01T13:17:49Z",
[2022-04-01T13:17:50.735Z]           		ExpireAt:  "",
[2022-04-01T13:17:50.735Z]           		... // 3 identical fields
[2022-04-01T13:17:50.735Z]           	},
[2022-04-01T13:17:50.735Z]           	{
[2022-04-01T13:17:50.735Z]           		ESDocument: model.ESDocument{
[2022-04-01T13:17:50.735Z]         - 			Id:      "c93fmvc2jgjfauojooe0",
[2022-04-01T13:17:50.735Z]         + 			Id:      "c93fmvc2jgjfauojood0",
[2022-04-01T13:17:50.735Z]           			Version: 0,
[2022-04-01T13:17:50.735Z]           			SeqNo:   0,
[2022-04-01T13:17:50.735Z]           		},
[2022-04-01T13:17:50.735Z]           		Active:    true,
[2022-04-01T13:17:50.735Z]           		ApiKey:    "d2JndlFIWUJJUVVxWDVia2NJTV86X0d6ZmljZGNTc1d4R1otbklrZFFRZw==",
[2022-04-01T13:17:50.735Z]         - 		ApiKeyId:  "c93fmvc2jgjfauojooeg",
[2022-04-01T13:17:50.735Z]         + 		ApiKeyId:  "c93fmvc2jgjfauojoodg",
[2022-04-01T13:17:50.735Z]           		CreatedAt: "2022-04-01T13:17:49Z",
[2022-04-01T13:17:50.735Z]           		ExpireAt:  "",
[2022-04-01T13:17:50.735Z]           		... // 3 identical fields
[2022-04-01T13:17:50.735Z]           	},
[2022-04-01T13:17:50.735Z]           }
[2022-04-01T13:17:50.735Z]         
[2022-04-01T13:17:50.735Z] --- FAIL: TestSearchEnrollmentAPIKeyByPolicyID (1.10s)```
@ph ph added flaky-test Unstable or unreliable test cases. Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Apr 1, 2022
@ph
Copy link
Contributor Author

ph commented Apr 4, 2022

Saw in #1306

@ph ph mentioned this issue Apr 4, 2022
Merged
ph added a commit to ph/fleet-server that referenced this issue Apr 4, 2022
@ph
Flaky test enrollment_api_key_integration_test.go
c03b6f9 
See elastic#1289
for more details
@ph ph mentioned this issue Apr 4, 2022
Merged
mergify bot pushed a commit that referenced this issue Apr 5, 2022
@ph
Flaky test enrollment_api_key_integration_test.go
6543fb2 
See #1289
for more details

(cherry picked from commit c03b6f9)
mergify bot added a commit that referenced this issue Apr 5, 2022
@mergify @ph
Flaky test enrollment_api_key_integration_test.go (#1314)
0a796ce 
See #1289
for more details

(cherry picked from commit c03b6f9)

Co-authored-by: Pier-Hugues Pellerin <phpellerin@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@michel-laterman michel-laterman mentioned this issue Oct 31, 2022
Merged
3 tasks
@michel-laterman
Copy link
Contributor

have not seen this in a while, will close for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
8.5-candidate flaky-test Unstable or unreliable test cases. Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ph @jlind23 @michel-laterman