Change fleet-server to use changelog tool #2499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create changelog fragments and log for 8.7.0 release and remove the old changelog. Use changelog tool for all new changes.
michel-laterman
added
documentation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
|
@kilfoyle, it looks like at least part of your wish has come true! @michel-laterman is looking to backport this enhancement to 8.7 for patch releases. Depending on the timing, we might be able to give it a try for next week's release. Related: elastic/ingest-docs#124 |
|
Michel, this is terrific. However I can help, please let me know! |
kpollich
approved these changes
Apr 17, 2023
| @@ -31,7 +31,7 @@ This checklist is a reminder about high level design problems that should be con | |||
|
|
|||
| - [ ] I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer. | |||
| - [ ] I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected. | |||
| - [ ] I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc. | |||
| - [ ] I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc. | |||
There was a problem hiding this comment.
Greatly appreciate the updates to the templates here, these would have been easy to miss.
Co-authored-by: Kyle Pollich <kpollich1@gmail.com>
mergify bot
pushed a commit
that referenced
this pull request
Apr 17, 2023
* Change fleet-server to use changelog tool Create changelog fragments and log for 8.7.0 release and remove the old changelog. Use changelog tool for all new changes. * Apply suggestions from code review Co-authored-by: Kyle Pollich <kpollich1@gmail.com> --------- Co-authored-by: Kyle Pollich <kpollich1@gmail.com> (cherry picked from commit 4667d85) # Conflicts: # CHANGELOG.next.asciidoc # README.md
mergify bot
added a commit
that referenced
this pull request
Apr 17, 2023
* Change fleet-server to use changelog tool (#2499) * Change fleet-server to use changelog tool Create changelog fragments and log for 8.7.0 release and remove the old changelog. Use changelog tool for all new changes. * Apply suggestions from code review Co-authored-by: Kyle Pollich <kpollich1@gmail.com> --------- Co-authored-by: Kyle Pollich <kpollich1@gmail.com> (cherry picked from commit 4667d85) # Conflicts: # CHANGELOG.next.asciidoc # README.md * fix README --------- Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com> Co-authored-by: michel-laterman <michel.laterman@elastic.co>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create changelog fragments and log for 8.7.0 release and remove the old changelog. Use changelog tool for all new changes.