bulk_indexer: track all response status codes #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the bulk_indexer to track all response status codes and report them appropriately as metrics. Also refactors tests to make them more succinct. Signed-off-by: Marc Lopez Rubio <marc5.12@outlook.com>
obltmachine
added
the
safe-to-test
inge4pres
reviewed
Jun 11, 2024
Comment on lines
+542
to
+547
| type errorFlushFailed struct { | ||
| resp string | ||
| statusCode int | ||
| tooMany bool | ||
| clientError bool | ||
| serverError bool |
There was a problem hiding this comment.
one other option would be to have a typed error for each case, and then wrapping them into an error returned on the specific branch, but we can always change that later
carsonip
reviewed
Jun 11, 2024
1pkg
reviewed
Jun 11, 2024
bulk_indexer.go
Outdated
| if res.StatusCode == http.StatusTooManyRequests { | ||
| return resp, errorTooManyRequests{res: res} | ||
| e := errorFlushFailed{resp: res.String(), statusCode: res.StatusCode} | ||
| if res.StatusCode >= 400 { |
1pkg
reviewed
Jun 11, 2024
1pkg
previously approved these changes
Jun 11, 2024
Signed-off-by: Marc Lopez Rubio <marc5.12@outlook.com>
carsonip
reviewed
Jun 12, 2024
bulk_indexer.go
Outdated
| if res.StatusCode == http.StatusTooManyRequests { | ||
| return resp, errorTooManyRequests{res: res} | ||
| e := errorFlushFailed{resp: res.String(), statusCode: res.StatusCode} | ||
| if res.StatusCode >= 400 { |
There was a problem hiding this comment.
nit: can we have the switch case here as well? I find it more readable than nested if. Here we'll get the added benefit of fewer return statements.
Signed-off-by: Marc Lopez Rubio <marc5.12@outlook.com>
carsonip
approved these changes
Jun 12, 2024
codeboten
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Jul 9, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/elastic/go-docappender/v2](https://github.com/elastic/go-docappender) | `v2.1.4` -> `v2.2.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>elastic/go-docappender (github.com/elastic/go-docappender/v2)</summary> ### [`v2.2.0`](https://github.com/elastic/go-docappender/releases/tag/v2.2.0) [Compare Source](https://github.com/elastic/go-docappender/compare/v2.1.4...v2.2.0) ##### What's Changed - fix: update CODEOWNERS by [@​kruskall](https://github.com/kruskall) in [elastic/go-docappender#181 - bulk_indexer: track all response status codes by [@​marclop](https://github.com/marclop) in [elastic/go-docappender#177 - build(deps): bump github.com/klauspost/compress from 1.17.8 to 1.17.9 by [@​dependabot](https://github.com/dependabot) in [elastic/go-docappender#183 - add otel tracing support by [@​endorama](https://github.com/endorama) in [elastic/go-docappender#182 ##### New Contributors - [@​endorama](https://github.com/endorama) made their first contribution in [elastic/go-docappender#182 **Full Changelog**: elastic/go-docappender@v2.1.4...v2.2.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Yang Song <songy23@users.noreply.github.com>
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jul 11, 2024
](https://renovatebot.com){kind=link}
…lemetry#33967) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/elastic/go-docappender/v2](https://github.com/elastic/go-docappender) | `v2.1.4` -> `v2.2.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>elastic/go-docappender (github.com/elastic/go-docappender/v2)</summary> ### [`v2.2.0`](https://github.com/elastic/go-docappender/releases/tag/v2.2.0) [Compare Source](https://github.com/elastic/go-docappender/compare/v2.1.4...v2.2.0) ##### What's Changed - fix: update CODEOWNERS by [@&open-telemetry#8203;kruskall](https://github.com/kruskall) in [elastic/go-docappender#181 - bulk_indexer: track all response status codes by [@&open-telemetry#8203;marclop](https://github.com/marclop) in [elastic/go-docappender#177 - build(deps): bump github.com/klauspost/compress from 1.17.8 to 1.17.9 by [@&open-telemetry#8203;dependabot](https://github.com/dependabot) in [elastic/go-docappender#183 - add otel tracing support by [@&open-telemetry#8203;endorama](https://github.com/endorama) in [elastic/go-docappender#182 ##### New Contributors - [@&open-telemetry#8203;endorama](https://github.com/endorama) made their first contribution in [elastic/go-docappender#182 **Full Changelog**: elastic/go-docappender@v2.1.4...v2.2.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Yang Song <songy23@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the bulk_indexer to track all response status codes and report them appropriately as metrics. Also refactors tests to make them more succinct.
Closes #172