Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add otel tracing support #182

Merged
merged 24 commits into from
Jun 17, 2024
Merged

add otel tracing support #182

merged 24 commits into from
Jun 17, 2024

Commits on Jun 11, 2024

  1. add OtelTracer config

    @endorama
    endorama committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    9dabb54 View commit details
    Browse the repository at this point in the history

  2. update Appender.flush to use otel tracer 

    If APM tracer is not set and an otel tracer is configured use it
to trace the Appender.flush execution
    @endorama
    endorama committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    dabb278 View commit details
    Browse the repository at this point in the history

  3. detect otel tracer in Appender.tracingEnabled 

    As we want to support otel tracing report tracing enabled if its
configured. otel tracer will be checked only if there is no APM
tracer configured.
    @endorama
    endorama committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    cab7923 View commit details
    Browse the repository at this point in the history

  4. use otel tracer

    @endorama
    endorama committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    c97556c View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. otelTracingEnabled

    @endorama
    endorama committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    49fc649 View commit details
    Browse the repository at this point in the history

  2. add test

    @endorama
    endorama committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    046ad35 View commit details
    Browse the repository at this point in the history

  3. check if span is recording 

    As we are using a span previously initialized we can
ensure it's active before trying to record events on it.
    @endorama
    endorama committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    87d8cb3 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. use span variable

    @endorama
    endorama committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    827e13e View commit details
    Browse the repository at this point in the history

  2. do not shutdown exporter 

    As it's an in memory exporter shutting it down means
we can't get spans from it.
    @endorama
    endorama committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    957d4cd View commit details
    Browse the repository at this point in the history

  3. add tests

    @endorama
    endorama committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    c0064a3 View commit details
    Browse the repository at this point in the history

  4. pass tracer provider to Config 

    Instead of accepting a Tracer use more idiomatic code by
accepting a TracerProvider from which a Tracer is initialized
in New()
    @endorama
    endorama committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    9fa8259 View commit details
    Browse the repository at this point in the history

  5. test span status

    @endorama
    endorama committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    97baa63 View commit details
    Browse the repository at this point in the history

  6. document OtelTracerProvider

    @endorama
    endorama committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    97e7d5f View commit details
    Browse the repository at this point in the history

  7. move test code to file end

    @endorama
    endorama committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    735aebf View commit details
    Browse the repository at this point in the history

  8. test failure case

    @endorama
    endorama committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    bbee58b View commit details
    Browse the repository at this point in the history

  9. setStatus must be called manually 

    span.RecordError does not set span status, which must
be called manually.
    @endorama
    endorama committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    11de058 View commit details
    Browse the repository at this point in the history

  10. document otelTracingEnabled

    @endorama
    endorama committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    5867c7b View commit details
    Browse the repository at this point in the history

  11. update go.mod

    @endorama
    endorama committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    a9e18c2 View commit details
    Browse the repository at this point in the history

  12. remove comment

    @endorama
    endorama committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    27b0b86 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'main' into otel-tracing

    @endorama
    endorama committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    3038196 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. OtelTracerProvider -> TracerProvider

    @endorama
    endorama committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    6cc6cea View commit details
    Browse the repository at this point in the history

  2. add deprecation notice to Tracer

    @endorama
    endorama committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    a5fa1ad View commit details
    Browse the repository at this point in the history

  3. Update appender.go 

    Co-authored-by: Carson Ip <carsonip@users.noreply.github.com>
    @endorama @carsonip
    endorama and carsonip committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    deb950b View commit details
    Browse the repository at this point in the history

  4. go fmt

    @endorama
    endorama committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    a1aa8e8 View commit details
    Browse the repository at this point in the history