Revert change to Reassembler.Push from #116 #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reassembler.Push has always made a copy of the provided byte slice. It elastic#116 it was modified to not copy the slice. But this was a breaking change to its behavior and causes bugs for existing users. The typical use of this function is to parse data from AuditClient.Receive which explicitly documents that caller must make a copy of the data if they are going to retain it beyond the next Receive call. Relates elastic#116
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
andrewkroh
added
the
Team:Security-External Integrations
efd6
approved these changes
Aug 24, 2022
Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
andrewkroh
commented
Aug 24, 2022
renini
pushed a commit
to renini/go-libaudit
that referenced
this pull request
Jun 26, 2024
Reassembler.Push has always made a copy of the provided byte slice. It elastic#116 it was modified to not copy the slice. But this was a breaking change to its behavior and causes bugs for existing users. The typical use of this function is to parse data from AuditClient.Receive which explicitly documents that caller must make a copy of the data if they are going to retain it beyond the next Receive call. Relates elastic#116
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reassembler.Pushhas always made a copy of the provided byte slice.In #116 it was modified to not copy the slice. But this was a breaking change
to its behavior and causes bugs for existing users. The typical use of this
function is to parse data from
AuditClient.Receivewhich explicitly documentsthat caller must make a copy of the data if they are going to retain it beyond
the next
Receivecall.Relates #116