Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rule: add saddr_fam rule filter handling #145

Merged
merged 4 commits into from
Oct 23, 2023
Merged

rule: add saddr_fam rule filter handling #145

merged 4 commits into from
Oct 23, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Oct 17, 2023

Please take a look.

Closes #144

@efd6 efd6 added enhancement Team:Security-External Integrations Label for the Security External Integrations team labels Oct 17, 2023
@efd6 efd6 self-assigned this Oct 17, 2023
@efd6 efd6 requested review from andrewkroh and a team October 17, 2023 22:17
@efd6 efd6 marked this pull request as ready for review October 17, 2023 22:17
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one minor comment.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be generated from defs_kernel_types.go with go generate. Can you modify defs_kernel_types.go with the new field.

//go:generate sh -c "go tool cgo -godefs defs_kernel_types.go > zkernel_types.go && gofmt -w zkernel_types.go"

@efd6 efd6 requested a review from andrewkroh October 23, 2023 20:18
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @efd6

@efd6 efd6 merged commit 4e7f2a0 into main Oct 23, 2023
renini pushed a commit to renini/go-libaudit that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Team:Security-External Integrations Label for the Security External Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[rule] Add support for saddr_fam filters
3 participants