Fix integer overflow in BPF conditional jumps #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@starius Thanks for the patch. Would it be possible for you to add a test case to filter_test.go for this issue. Having a test case will help with reviewing and prevent a future regression. Thanks! |
If the list of syscalls is too long (>256) then the library sends incorrect BPF code and this results in crashes, because some syscalls are denied. This commit fixes the crash by splitting the list of syscalls into groups of size 256 in Policy.Assemble. Also I found another similar overflow in SyscallGroup.Assemble and fixed it as well.
|
@andrewkroh tests added. |
|
@andrewkroh |
|
I looked over the generated byte code and everything LGTM. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the list of syscalls is too long (>256) then the library sends incorrect
BPF code and this results in crashes, because some syscalls are denied. This
commit fixes the crash by splitting the list of syscalls into groups of
size 256 in Policy.Assemble. Also I found another similar overflow in
SyscallGroup.Assemble and fixed it as well.