Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIX: Added missing method FQDN for types.Host implementation #185

Merged
merged 2 commits into from
Jul 28, 2023
Merged

AIX: Added missing method FQDN for types.Host implementation #185

merged 2 commits into from
Jul 28, 2023

Conversation

asalih
Copy link
Contributor

@asalih asalih commented Jul 25, 2023

Encountered this issue while building on AIX 7.3. I have added the missing implementation.

# github.com/elastic/go-sysinfo/providers/aix
/go/pkg/mod/github.com/elastic/go-sysinfo@v1.11.0/providers/aix/host_aix_ppc64.go:57:9: cannot use newHost() (value of type *host) as types.Host value in return statement: *host does not implement types.Host (missing method FQDN)

@cla-checker-service
Copy link

cla-checker-service bot commented Jul 25, 2023

💚 CLA has been signed

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 25, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-28T17:07:19.607+0000

  • Duration: 14 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 167
Skipped 2
Total 169

@asalih
Copy link
Contributor Author

asalih commented Jul 25, 2023

I have signed the agreement before opening the pull request. Why does the bot still say it is unsigned?

@andrewkroh
Copy link
Member

I think it is because your git commit is not authored by email address used to sign the CLA. https://patch-diff.githubusercontent.com/raw/elastic/go-sysinfo/pull/185.patch

@asalih
Copy link
Contributor Author

asalih commented Jul 28, 2023

thank you @andrewkroh, I also signed it with that email as well.

@andrewkroh
Copy link
Member

/test

@andrewkroh andrewkroh added the bug Something isn't working label Jul 28, 2023
.changelog/185.txt Outdated Show resolved Hide resolved
@andrewkroh
Copy link
Member

/test

@andrewkroh andrewkroh changed the title Added missing method FQDN for types.Host implementation AIX: Added missing method FQDN for types.Host implementation Jul 28, 2023
@andrewkroh andrewkroh merged commit 6691673 into elastic:main Jul 28, 2023
22 checks passed
@andrewkroh
Copy link
Member

Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants