-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIX: Added missing method FQDN for types.Host implementation #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 CLA has been signed |
I have signed the agreement before opening the pull request. Why does the bot still say it is unsigned? |
I think it is because your git commit is not authored by email address used to sign the CLA. https://patch-diff.githubusercontent.com/raw/elastic/go-sysinfo/pull/185.patch |
thank you @andrewkroh, I also signed it with that email as well. |
/test |
andrewkroh
reviewed
Jul 28, 2023
/test |
andrewkroh
changed the title
Added missing method FQDN for types.Host implementation
AIX: Added missing method FQDN for types.Host implementation
Jul 28, 2023
andrewkroh
approved these changes
Jul 28, 2023
Thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encountered this issue while building on AIX 7.3. I have added the missing implementation.