Apply validation to default values even when values do not come from the configuration #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the configuration.
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
==========================================
+ Coverage 78.05% 78.36% +0.31%
==========================================
Files 24 24
Lines 2643 2709 +66
==========================================
+ Hits 2063 2123 +60
- Misses 428 431 +3
- Partials 152 155 +3
Continue to review full report at Codecov.
|
urso
reviewed
Jan 28, 2020
…er array and map passed to Unpack for default validation. Factor out a accessField helper that both validation path and reify path can use.
|
@urso PR is ready for another review. |
urso
reviewed
Jan 28, 2020
urso
reviewed
Jan 28, 2020
…torTags into the accessField function.
urso
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When unpacking into an object that already has values present but the configuration doesn't contains values for those objects still apply validation to the objects existing values. This is to ensure that even defaults that might already be set in the object that is passed to Unpack adheres to the same validation rules that the configuration must adhere to.
This also contains a fix on how validateRequired would return an ErrEmpty error instead of an ErrRequired. When using the
validate:"required"tag the error message should match the tag applied.Closes #42